-
Notifications
You must be signed in to change notification settings - Fork 314
Sync eng/common directory with azure-sdk-tools for PR 12410 #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync eng/common directory with azure-sdk-tools for PR 12410 #3144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds optional ArtifactsJson input (alongside or instead of PackageNames) to set test pipeline package versions and updates the YAML template to use strongly-typed parameters. Core change introduces a new code path for deriving package names and version tags from artifact metadata.
- Added ArtifactsJson parameter and logic to parse and process artifacts (including Java groupId handling)
- Made PackageNames optional and updated YAML parameter schema to typed form
- Introduced parallel (duplicated) version resolution logic for the new artifacts path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
eng/common/scripts/SetTestPipelineVersion.ps1 | Adds ArtifactsJson handling, optional PackageNames, and artifact-aware version/tag computation. |
eng/common/pipelines/templates/steps/set-test-pipeline-version.yml | Converts parameters to typed form and plumbs through new ArtifactsJson argument. |
Comments suppressed due to low confidence (1)
eng/common/scripts/SetTestPipelineVersion.ps1:108
- [nitpick] The version/tag resolution logic (initializing newVersion, computing prefix, fetching tags, sorting, setting prerelease fields, and calling SetPackageVersion) is duplicated between the artifacts branch and the fallback loop; this increases maintenance overhead and risk of divergence. Extract the shared logic into a helper function (e.g., Resolve-And-SetPackageVersion -PackageName [-GroupId]) and invoke it from both branches.
foreach ($packageName in $packageNamesArray) {
Write-Host "Processing $packageName"
$newVersion = [AzureEngSemanticVersion]::new("1.0.0")
$prefix = "$packageName$TagSeparator"
eng/common/pipelines/templates/steps/set-test-pipeline-version.yml
Outdated
Show resolved
Hide resolved
ea17449
to
46ff904
Compare
/check-enforcer override |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12410 See eng/common workflow