Skip to content

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12410 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner October 7, 2025 23:57
@azure-sdk azure-sdk requested review from Copilot and raych1 October 7, 2025 23:57
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds optional ArtifactsJson input (alongside or instead of PackageNames) to set test pipeline package versions and updates the YAML template to use strongly-typed parameters. Core change introduces a new code path for deriving package names and version tags from artifact metadata.

  • Added ArtifactsJson parameter and logic to parse and process artifacts (including Java groupId handling)
  • Made PackageNames optional and updated YAML parameter schema to typed form
  • Introduced parallel (duplicated) version resolution logic for the new artifacts path

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/common/scripts/SetTestPipelineVersion.ps1 Adds ArtifactsJson handling, optional PackageNames, and artifact-aware version/tag computation.
eng/common/pipelines/templates/steps/set-test-pipeline-version.yml Converts parameters to typed form and plumbs through new ArtifactsJson argument.
Comments suppressed due to low confidence (1)

eng/common/scripts/SetTestPipelineVersion.ps1:108

  • [nitpick] The version/tag resolution logic (initializing newVersion, computing prefix, fetching tags, sorting, setting prerelease fields, and calling SetPackageVersion) is duplicated between the artifacts branch and the fallback loop; this increases maintenance overhead and risk of divergence. Extract the shared logic into a helper function (e.g., Resolve-And-SetPackageVersion -PackageName [-GroupId]) and invoke it from both branches.
  foreach ($packageName in $packageNamesArray) {
    Write-Host "Processing $packageName"
    $newVersion = [AzureEngSemanticVersion]::new("1.0.0")
    $prefix = "$packageName$TagSeparator"

@azure-sdk azure-sdk force-pushed the sync-eng/common-users/raych1/test-pipeline-updates-12410 branch from ea17449 to 46ff904 Compare October 10, 2025 22:39
@raych1
Copy link
Member

raych1 commented Oct 13, 2025

/check-enforcer override

@azure-sdk azure-sdk merged commit 9d19c08 into main Oct 13, 2025
17 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-users/raych1/test-pipeline-updates-12410 branch October 13, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants